-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feature: add warnings for xgboost specific rules in debugger rules #3255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: fix that failing in debugger rules leads to end training jobs with no message
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## master #3255 +/- ##
==========================================
- Coverage 88.79% 88.78% -0.01%
==========================================
Files 203 203
Lines 17978 17983 +5
==========================================
+ Hits 15963 15967 +4
- Misses 2015 2016 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
fix: fix that failing in certain debugger rules leads to end training jobs with no description.
Issue #, if available: There are debugger rules that are valid only for XGBoost algorithms, but there is no warning or error message for users when the rules are incorrectly used.
Description of changes: Add warning for using XBGoost debugger rules outside of XGBoost algorithms.
Testing done: Passed all unit tests.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.